From 072dcafe388a4fb27eee5c9fbbea2ce0eb03f20c Mon Sep 17 00:00:00 2001 From: Ankit Kumar Date: Mon, 2 Mar 2026 03:11:13 +0530 Subject: [PATCH] Add missing logging to TridentBoltExecutor on tuple count mismatch failures --- .../apache/storm/trident/topology/TridentBoltExecutor.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/storm-client/src/jvm/org/apache/storm/trident/topology/TridentBoltExecutor.java b/storm-client/src/jvm/org/apache/storm/trident/topology/TridentBoltExecutor.java index 11b61fbc329..9863c36fc50 100644 --- a/storm-client/src/jvm/org/apache/storm/trident/topology/TridentBoltExecutor.java +++ b/storm-client/src/jvm/org/apache/storm/trident/topology/TridentBoltExecutor.java @@ -40,9 +40,13 @@ import org.apache.storm.utils.RotatingMap; import org.apache.storm.utils.TupleUtils; import org.apache.storm.utils.Utils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; public class TridentBoltExecutor implements IRichBolt { public static final String COORD_STREAM_PREFIX = "$coord-"; + private static final Logger LOG = LoggerFactory.getLogger(TridentBoltExecutor.class); + Map batchGroupIds; Map coordSpecs; Map coordConditions; @@ -160,7 +164,8 @@ private void checkFinish(TrackedBatch tracked, Tuple tuple, TupleType type) { if (tracked.receivedTuples == tracked.expectedTupleCount) { finishBatch(tracked, tuple); } else { - //TODO: add logging that not all tuples were received + LOG.warn("Failing batch {}: expected {} tuples but only received {}", + tracked.info.batchId, tracked.expectedTupleCount, tracked.receivedTuples); failBatch(tracked); collector.fail(tuple); failed = true;