From e4a05432ebcc83626b8be06f19696d2abe3998ec Mon Sep 17 00:00:00 2001 From: Ankit Kumar Date: Mon, 2 Mar 2026 03:03:57 +0530 Subject: [PATCH] Replace e.printStackTrace() with SLF4J logging in ConfigurableTopology#submit --- .../jvm/org/apache/storm/topology/ConfigurableTopology.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/storm-client/src/jvm/org/apache/storm/topology/ConfigurableTopology.java b/storm-client/src/jvm/org/apache/storm/topology/ConfigurableTopology.java index b80ac19bc9f..b3f52a0beed 100644 --- a/storm-client/src/jvm/org/apache/storm/topology/ConfigurableTopology.java +++ b/storm-client/src/jvm/org/apache/storm/topology/ConfigurableTopology.java @@ -35,6 +35,8 @@ import org.apache.storm.shade.org.yaml.snakeyaml.Yaml; import org.apache.storm.shade.org.yaml.snakeyaml.constructor.SafeConstructor; import org.apache.storm.utils.Utils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; /** * Extensions of this class takes a reference to one or more configuration files. The main() method should call ConfigurableTopology.start() @@ -60,6 +62,7 @@ * **/ public abstract class ConfigurableTopology { + private static final Logger LOG = LoggerFactory.getLogger(ConfigurableTopology.class); protected Config conf = new Config(); @@ -120,7 +123,7 @@ protected int submit(String name, Config conf, TopologyBuilder builder) { StormSubmitter.submitTopology(name, conf, builder.createTopology()); } catch (Exception e) { - e.printStackTrace(); + LOG.error("Failed to submit topology {}", name, e); return -1; } return 0;