From 51da33b2e3edc30305061ce06d695dee7e93977f Mon Sep 17 00:00:00 2001 From: andevellicus <762254+andevellicus@users.noreply.github.com> Date: Mon, 8 Jun 2020 18:15:00 -0400 Subject: [PATCH 1/4] Update visualize.jl matchall has been deprecated as of Julia 1.3. Changes made to fix. --- julia/src/visualize.jl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/julia/src/visualize.jl b/julia/src/visualize.jl index ddbb3c11fe9b..4053b8702b16 100644 --- a/julia/src/visualize.jl +++ b/julia/src/visualize.jl @@ -207,7 +207,9 @@ function _format_graphviz_edge(io::IOBuffer, head, tail, attrs) _format_graphviz_attr(io, attrs) end function _extract_shape(str :: AbstractString) - shape = matchall(r"\d+", str) + #shape = matchall(r"\d+", str) + shape = collect(m.match for m in eachmatch(r"\d+", str)) + shape = reverse(shape) # JSON in libmxnet has reversed shape (column vs row majoring) return "(" * join(shape, ",") * ")" end From 29a8cb6ba19804851bdb8a6f54c142fa5f77cebe Mon Sep 17 00:00:00 2001 From: andevellicus <762254+andevellicus@users.noreply.github.com> Date: Mon, 8 Jun 2020 18:29:56 -0400 Subject: [PATCH 2/4] Cleaned --- julia/src/visualize.jl | 1 - 1 file changed, 1 deletion(-) diff --git a/julia/src/visualize.jl b/julia/src/visualize.jl index 4053b8702b16..3a83f895ec24 100644 --- a/julia/src/visualize.jl +++ b/julia/src/visualize.jl @@ -207,7 +207,6 @@ function _format_graphviz_edge(io::IOBuffer, head, tail, attrs) _format_graphviz_attr(io, attrs) end function _extract_shape(str :: AbstractString) - #shape = matchall(r"\d+", str) shape = collect(m.match for m in eachmatch(r"\d+", str)) shape = reverse(shape) # JSON in libmxnet has reversed shape (column vs row majoring) From 8b156884b2b32a78e782a0ccc827c6d19c617b4a Mon Sep 17 00:00:00 2001 From: Iblis Lin Date: Wed, 10 Jun 2020 17:21:33 +0800 Subject: [PATCH 3/4] Update julia/src/visualize.jl --- julia/src/visualize.jl | 1 - 1 file changed, 1 deletion(-) diff --git a/julia/src/visualize.jl b/julia/src/visualize.jl index 3a83f895ec24..cd3c6158d177 100644 --- a/julia/src/visualize.jl +++ b/julia/src/visualize.jl @@ -208,7 +208,6 @@ function _format_graphviz_edge(io::IOBuffer, head, tail, attrs) end function _extract_shape(str :: AbstractString) shape = collect(m.match for m in eachmatch(r"\d+", str)) - shape = reverse(shape) # JSON in libmxnet has reversed shape (column vs row majoring) return "(" * join(shape, ",") * ")" end From f3bad1857f56070e17274fe62b1d94a261ff74b4 Mon Sep 17 00:00:00 2001 From: Iblis Lin Date: Wed, 10 Jun 2020 17:22:23 +0800 Subject: [PATCH 4/4] Update julia/src/visualize.jl --- julia/src/visualize.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/julia/src/visualize.jl b/julia/src/visualize.jl index cd3c6158d177..849b784779ea 100644 --- a/julia/src/visualize.jl +++ b/julia/src/visualize.jl @@ -207,7 +207,7 @@ function _format_graphviz_edge(io::IOBuffer, head, tail, attrs) _format_graphviz_attr(io, attrs) end function _extract_shape(str :: AbstractString) - shape = collect(m.match for m in eachmatch(r"\d+", str)) + shape = collect(m.match for m ∈ eachmatch(r"\d+", str)) shape = reverse(shape) # JSON in libmxnet has reversed shape (column vs row majoring) return "(" * join(shape, ",") * ")" end