From d8e433cb91634ade4285feef4ba703228fc83a51 Mon Sep 17 00:00:00 2001 From: Weijun Huang Date: Fri, 10 Nov 2023 14:13:36 +0100 Subject: [PATCH] Minor: clean up the code regarding clippy --- .../core/src/physical_optimizer/limited_distinct_aggregation.rs | 2 +- datafusion/physical-plan/src/limit.rs | 2 +- datafusion/sql/src/statement.rs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/datafusion/core/src/physical_optimizer/limited_distinct_aggregation.rs b/datafusion/core/src/physical_optimizer/limited_distinct_aggregation.rs index 832a92bb69c6a..8f5dbc2e9214b 100644 --- a/datafusion/core/src/physical_optimizer/limited_distinct_aggregation.rs +++ b/datafusion/core/src/physical_optimizer/limited_distinct_aggregation.rs @@ -57,7 +57,7 @@ impl LimitedDistinctAggregation { aggr.filter_expr().to_vec(), aggr.order_by_expr().to_vec(), aggr.input().clone(), - aggr.input_schema().clone(), + aggr.input_schema(), ) .expect("Unable to copy Aggregate!") .with_limit(Some(limit)); diff --git a/datafusion/physical-plan/src/limit.rs b/datafusion/physical-plan/src/limit.rs index c8427f9bc2c66..355561c36f35f 100644 --- a/datafusion/physical-plan/src/limit.rs +++ b/datafusion/physical-plan/src/limit.rs @@ -229,7 +229,7 @@ impl ExecutionPlan for GlobalLimitExec { let remaining_rows: usize = nr - skip; let mut skip_some_rows_stats = Statistics { num_rows: Precision::Exact(remaining_rows), - column_statistics: col_stats.clone(), + column_statistics: col_stats, total_byte_size: Precision::Absent, }; if !input_stats.num_rows.is_exact().unwrap_or(false) { diff --git a/datafusion/sql/src/statement.rs b/datafusion/sql/src/statement.rs index 116624c6f7b97..ecc77b0442235 100644 --- a/datafusion/sql/src/statement.rs +++ b/datafusion/sql/src/statement.rs @@ -1017,7 +1017,7 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> { expr_to_columns(&filter_expr, &mut using_columns)?; let filter_expr = normalize_col_with_schemas_and_ambiguity_check( filter_expr, - &[&[&scan.schema()]], + &[&[scan.schema()]], &[using_columns], )?; LogicalPlan::Filter(Filter::try_new(filter_expr, Arc::new(scan))?)