Add Worker hashes for Golang#38754
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces support for passing worker binary hashes to the Dataflow runner in the Go SDK. By including the SHA-256 hash in the worker package metadata, the system can better verify worker integrity and ensure consistency during pipeline execution. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds support for tracking and verifying the SHA-256 hash of the worker binary in the Dataflow runner. It introduces a WorkerHash field to JobOptions, sets it during execution, includes it in the worker package metadata, and adds unit tests to verify this behavior. The review feedback suggests improving the robustness of the unit test by searching for the "worker" package in the packages list rather than assuming it is the first and only element.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #38754 +/- ##
============================================
- Coverage 55.82% 55.80% -0.02%
Complexity 2111 2111
============================================
Files 1102 1102
Lines 172482 172590 +108
Branches 1357 1357
============================================
+ Hits 96282 96319 +37
- Misses 73806 73875 +69
- Partials 2394 2396 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Assigning reviewers: R: @jrmccluskey for label go. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
R: @Abacn |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Tested Worker Hashes get transferred to metadata on my worker pipeline.

GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.