Skip to content

Add Worker hashes for Golang#38754

Merged
Abacn merged 2 commits into
apache:masterfrom
tarun-google:add_go_hashes
Jun 1, 2026
Merged

Add Worker hashes for Golang#38754
Abacn merged 2 commits into
apache:masterfrom
tarun-google:add_go_hashes

Conversation

@tarun-google
Copy link
Copy Markdown
Contributor

Tested Worker Hashes get transferred to metadata on my worker pipeline.
Screenshot 2026-05-31 at 3 35 35 PM

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces support for passing worker binary hashes to the Dataflow runner in the Go SDK. By including the SHA-256 hash in the worker package metadata, the system can better verify worker integrity and ensure consistency during pipeline execution.

Highlights

  • Worker Hash Support: Added a new WorkerHash field to JobOptions to track the SHA-256 hash of the worker binary.
  • Metadata Integration: Updated the Dataflow runner to include the worker binary's SHA-256 hash in the package metadata during job translation.
  • Testing: Added unit tests to verify that the worker package correctly includes the expected SHA-256 hash.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for tracking and verifying the SHA-256 hash of the worker binary in the Dataflow runner. It introduces a WorkerHash field to JobOptions, sets it during execution, includes it in the worker package metadata, and adds unit tests to verify this behavior. The review feedback suggests improving the robustness of the unit test by searching for the "worker" package in the packages list rather than assuming it is the first and only element.

Comment thread sdks/go/pkg/beam/runners/dataflow/dataflowlib/job_test.go
@codecov
Copy link
Copy Markdown

codecov Bot commented May 31, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 55.80%. Comparing base (1b261f0) to head (d1f595f).
⚠️ Report is 40 commits behind head on master.

Files with missing lines Patch % Lines
...o/pkg/beam/runners/dataflow/dataflowlib/execute.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #38754      +/-   ##
============================================
- Coverage     55.82%   55.80%   -0.02%     
  Complexity     2111     2111              
============================================
  Files          1102     1102              
  Lines        172482   172590     +108     
  Branches       1357     1357              
============================================
+ Hits          96282    96319      +37     
- Misses        73806    73875      +69     
- Partials       2394     2396       +2     
Flag Coverage Δ
go 28.73% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @jrmccluskey for label go.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@tarun-google
Copy link
Copy Markdown
Contributor Author

R: @Abacn

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 1, 2026

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Copy Markdown
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Abacn Abacn merged commit 2400917 into apache:master Jun 1, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants