From af2461cd78cad52e886348afd213835452ae5334 Mon Sep 17 00:00:00 2001 From: Jed Cunningham Date: Fri, 17 May 2024 14:37:41 -0600 Subject: [PATCH 1/2] More typing in TimeSensor and TimeSensorAsync --- airflow/sensors/time_sensor.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/airflow/sensors/time_sensor.py b/airflow/sensors/time_sensor.py index cc07323ca1da9..f0b72ed85a371 100644 --- a/airflow/sensors/time_sensor.py +++ b/airflow/sensors/time_sensor.py @@ -40,11 +40,11 @@ class TimeSensor(BaseSensorOperator): """ - def __init__(self, *, target_time, **kwargs): + def __init__(self, *, target_time: datetime.time, **kwargs) -> None: super().__init__(**kwargs) self.target_time = target_time - def poke(self, context: Context): + def poke(self, context: Context) -> bool: self.log.info("Checking if the time (%s) has come", self.target_time) return timezone.make_naive(timezone.utcnow(), self.dag.timezone).time() > self.target_time @@ -62,7 +62,7 @@ class TimeSensorAsync(BaseSensorOperator): :ref:`howto/operator:TimeSensorAsync` """ - def __init__(self, *, target_time, **kwargs): + def __init__(self, *, target_time: datetime.time, **kwargs) -> None: super().__init__(**kwargs) self.target_time = target_time @@ -72,13 +72,13 @@ def __init__(self, *, target_time, **kwargs): self.target_datetime = timezone.convert_to_utc(aware_time) - def execute(self, context: Context): + def execute(self, context: Context) -> None: trigger = DateTimeTrigger(moment=self.target_datetime) self.defer( trigger=trigger, method_name="execute_complete", ) - def execute_complete(self, context, event=None): + def execute_complete(self, context, event=None) -> None: """Execute when the trigger fires - returns immediately.""" return None From bcaf1ea4ae5ca20591093102bad4e72faae13b18 Mon Sep 17 00:00:00 2001 From: Jed Cunningham Date: Mon, 20 May 2024 16:12:12 -0600 Subject: [PATCH 2/2] Remove typing for async execute --- airflow/sensors/time_sensor.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/airflow/sensors/time_sensor.py b/airflow/sensors/time_sensor.py index f0b72ed85a371..6df67bc855b24 100644 --- a/airflow/sensors/time_sensor.py +++ b/airflow/sensors/time_sensor.py @@ -72,7 +72,7 @@ def __init__(self, *, target_time: datetime.time, **kwargs) -> None: self.target_datetime = timezone.convert_to_utc(aware_time) - def execute(self, context: Context) -> None: + def execute(self, context: Context): trigger = DateTimeTrigger(moment=self.target_datetime) self.defer( trigger=trigger,