From d08e5c0d09264e680a419e54417ff4dfe6b251f1 Mon Sep 17 00:00:00 2001 From: Pankaj Koti Date: Mon, 19 Feb 2024 19:27:27 +0530 Subject: [PATCH 1/2] Add informative logs in KPO trigger until container has not finished --- airflow/providers/cncf/kubernetes/triggers/pod.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/airflow/providers/cncf/kubernetes/triggers/pod.py b/airflow/providers/cncf/kubernetes/triggers/pod.py index b88c2851c7175..0a7a137172e8a 100644 --- a/airflow/providers/cncf/kubernetes/triggers/pod.py +++ b/airflow/providers/cncf/kubernetes/triggers/pod.py @@ -262,6 +262,7 @@ async def _wait_for_container_completion(self) -> TriggerEvent: "last_log_time": self.last_log_time, } ) + self.log.info("Container is not completed and still working.") if time_get_more_logs and datetime.datetime.now(tz=datetime.timezone.utc) > time_get_more_logs: return TriggerEvent( { @@ -271,6 +272,7 @@ async def _wait_for_container_completion(self) -> TriggerEvent: "name": self.pod_name, } ) + self.log.info("Sleeping for %s seconds.", self.poll_interval) await asyncio.sleep(self.poll_interval) def _get_async_hook(self) -> AsyncKubernetesHook: From 87ee37bfa31de040ba6a0713594c608e6d290721 Mon Sep 17 00:00:00 2001 From: Pankaj Koti Date: Tue, 20 Feb 2024 22:18:09 +0530 Subject: [PATCH 2/2] Apply suggestions from code review --- airflow/providers/cncf/kubernetes/triggers/pod.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/airflow/providers/cncf/kubernetes/triggers/pod.py b/airflow/providers/cncf/kubernetes/triggers/pod.py index 0a7a137172e8a..b74e3ef877b1d 100644 --- a/airflow/providers/cncf/kubernetes/triggers/pod.py +++ b/airflow/providers/cncf/kubernetes/triggers/pod.py @@ -262,7 +262,7 @@ async def _wait_for_container_completion(self) -> TriggerEvent: "last_log_time": self.last_log_time, } ) - self.log.info("Container is not completed and still working.") + self.log.debug("Container is not completed and still working.") if time_get_more_logs and datetime.datetime.now(tz=datetime.timezone.utc) > time_get_more_logs: return TriggerEvent( { @@ -272,7 +272,7 @@ async def _wait_for_container_completion(self) -> TriggerEvent: "name": self.pod_name, } ) - self.log.info("Sleeping for %s seconds.", self.poll_interval) + self.log.debug("Sleeping for %s seconds.", self.poll_interval) await asyncio.sleep(self.poll_interval) def _get_async_hook(self) -> AsyncKubernetesHook: