From 9980ea0040a57b106131be035386df400c63afec Mon Sep 17 00:00:00 2001 From: Jarek Potiuk Date: Sat, 15 Apr 2023 14:24:24 +0200 Subject: [PATCH] Properly classify google_vendor package to google provider We've recently added google_venor package to vendor-in ads library, and we had to do it outside of regular google provider package, because internally the library assumed our google package is top level package when discovering the right relative imports (#30544). This confused the pre-commit that updates provider depedencies to not recognise the package and print warnings about bad classification. Special case handling will classify it to google provider. --- .../ci/pre_commit/pre_commit_update_providers_dependencies.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/ci/pre_commit/pre_commit_update_providers_dependencies.py b/scripts/ci/pre_commit/pre_commit_update_providers_dependencies.py index a66bb7f05ba97..f19e732c9b8aa 100755 --- a/scripts/ci/pre_commit/pre_commit_update_providers_dependencies.py +++ b/scripts/ci/pre_commit/pre_commit_update_providers_dependencies.py @@ -114,6 +114,8 @@ def get_provider_id_from_relative_import_or_file(relative_path_or_file: str) -> provider_candidate = relative_path_or_file.replace(os.sep, ".").split(".") while len(provider_candidate) > 0: candidate_provider_id = ".".join(provider_candidate) + if "google_vendor" in candidate_provider_id: + candidate_provider_id = candidate_provider_id.replace("google_vendor", "google") if candidate_provider_id in ALL_PROVIDERS: return candidate_provider_id provider_candidate = provider_candidate[:-1]