Skip to content

fix: upgrade playwright and deps#879

Merged
dylantientcheu merged 7 commits into
masterfrom
fix/update-playwright-deps-and-optimize
Sep 6, 2024
Merged

fix: upgrade playwright and deps#879
dylantientcheu merged 7 commits into
masterfrom
fix/update-playwright-deps-and-optimize

Conversation

@dylantientcheu

Copy link
Copy Markdown
Collaborator

In this PR:
A little housekeeping and improvements:

  • update Playwright to its latest version - will help improve performance and use latest browsers updates
  • update Express to its latest minor
  • Add a few more flags to the browser's launch to help optimize javascript rendering (search on this list for what they can do) LMK if you prefer in depth explanation on why I think the flags would work.

sbellone
sbellone previously approved these changes Jun 17, 2024

@sbellone sbellone left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for handling that 💪

8bittitan
8bittitan previously approved these changes Jun 26, 2024
@dylantientcheu dylantientcheu dismissed stale reviews from 8bittitan and sbellone via 31cf095 July 16, 2024 14:36

@NatanTechofNY NatanTechofNY left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can we make sure this is fully tested and working before merged?

@dylantientcheu dylantientcheu merged commit 0ab0095 into master Sep 6, 2024
algolia-bot added a commit that referenced this pull request Sep 6, 2024
## [2.2.17](v2.2.16...v2.2.17) (2024-09-06)

### Bug Fixes

* upgrade playwright and deps ([#879](#879)) ([0ab0095](0ab0095))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants