Skip to content

fix(workflows): allow Special parameters to have Intervals#508

Merged
prasad-albert merged 1 commit into
mainfrom
worktree-fix+workflow-interval
May 22, 2026
Merged

fix(workflows): allow Special parameters to have Intervals#508
prasad-albert merged 1 commit into
mainfrom
worktree-fix+workflow-interval

Conversation

@prasad-albert
Copy link
Copy Markdown
Collaborator

Summary

  • Removes the validator in ParameterSetpoint that incorrectly blocked category=Special parameters from having Intervals — the backend supports intervalizing Equipment, Consumables, and Template parameters
  • Adds name: str | None to Interval to capture the display name returned for Special parameter interval values (e.g. "Pipette 0.01 -0.1 ml (10 - 100 μl)")
  • Adds IntervalDetail model and interval_details field to IntervalCombination to expose the per-parameter breakdown from the /intervals endpoint

@claude
Copy link
Copy Markdown

claude Bot commented May 19, 2026

Looks good - no bugs or correctness issues found.

- Remove the validator that blocked `category=Special` + `Intervals`
  on `ParameterSetpoint`; the backend supports intervalizing Equipment,
  Consumables, and Template parameters
- Add `name` field to `Interval` to capture the display name returned
  for Special parameter interval values (e.g. inventory item name)
- Add `IntervalDetail` model and wire it into `IntervalCombination.interval_details`
  to expose the per-parameter breakdown from the `/intervals` endpoint
@prasad-albert prasad-albert force-pushed the worktree-fix+workflow-interval branch from 9e6e3da to 98d007c Compare May 19, 2026 05:14
@prasad-albert prasad-albert merged commit 167b8d4 into main May 22, 2026
2 checks passed
@prasad-albert prasad-albert deleted the worktree-fix+workflow-interval branch May 22, 2026 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants