Merged
Conversation
ghost
mentioned this pull request
magrinj
added a commit
to magrinj/react-native-maps
that referenced
this pull request
Jan 17, 2017
|
Thanks 🍻! |
|
when will this be released? |
pinpong
pushed a commit
to pinpong/react-native-maps
that referenced
this pull request
Feb 28, 2025
…onPress-fix Fixed issue react-native-maps#286.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issue #286.
Description:
The issue relates to getAnnotationView method.
A tap gesture is added to
AirMapMarkerview inAirMapMarkerManagerclass which listens to tap/press events on annotation view as well as callout view. But whenshouldUsePinViewreturnstrue, the annotation view on map is aMKPinAnnotationViewinstead ofAirMapMarkerand there is no tap gesture listener on this MKPinAnnotationView.Fix:
Now the Tap gesture is listened by the
AirMapMarkerclass itself and gesture now added to MKPinAnnotationView as well.