fix: Avoid event loop timing causing out of order messages#130
Merged
benbrandt merged 3 commits intoagentclientprotocol:mainfrom Apr 23, 2026
Merged
fix: Avoid event loop timing causing out of order messages#130benbrandt merged 3 commits intoagentclientprotocol:mainfrom
benbrandt merged 3 commits intoagentclientprotocol:mainfrom
Conversation
anvilpete
force-pushed
the
response-handler-wait
branch
from
b915e18 to
ee088a5
Compare
Send requests without awaiting `sendMessage` and remove the extra zero-delay yield after processing each message. This prevents unnecessary event-loop stalls while preserving pending response rejection handling if the transport closes.
Member
|
Looks like the real issue was the await on the send message |
benbrandt
changed the title
Contributor
Author
|
Even better - thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #128.
Added a test for this out-of-order processing, and another to check for deadlock when sending a request from a request handler.