fix: make elementProperties values selectable #57#62
Conversation
In the packages/core/src/components/Label the .parent had set the user-select property as none. This has now been switched to text and it works. Reviewed by: Goulielmos Floros Ref: ThatOpen#57
|
Hey @GoulielmosFloros! I fact, back in the day I intentionally set the user-select property to none. I don't remember why 😅, but I don't see why don't leave it as text based on your suggestion. Just one question before merging this... If you you set the property in the CSS file of the table example, does it have effect? |
|
Hi @HoyosJuan, I did try to set the user-access directly in the styles, also tried it from the developer tools on chrome to play around by adding it to parent elements and the shadow elements as well, but no it was not working. It was showing as it is taking place, but when you tried to select a value it was not working. Also, I tried to mark it as important in case it could supersede any other style applied, but still it was showing in the styles in chrome that it is active, but it was not working. Only when I changed it from the Label it worked. Although, the cursor which was not set in the label.ts file as text when I was adding it in the style directly it worked. Another solution could be to remove the user-select entirely and let the person who writes the script to modify it themselves in the style directly. |
2 participants
Description
In the packages/core/src/components/Label the .parent had set the user-select property as none.
This has now been switched to text and it works.
Reviewed by: Goulielmos Floros
Ref: #57
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following:
feat(examples): add hello-world example).fixes #123).