fix: address code review comments (cont.)

Author: ross-rosario

src/LowLevel/SecurityTokenRegistry.ts

@@ -11,11 +11,11 @@ import {
   GetSecurityTokenArgs,
   GetTickerDetailsArgs,
   IsTickerAvailableArgs,
-  TickerDetails,
 } from './types';
 import { fromWei } from './utils';
 import { PolymathError } from '../PolymathError';
 import { ErrorCodes } from '../types';
+import { ZERO_ADDRESS } from './constants';
 
 interface SecurityTokenRegistryContract extends GenericContract {
   methods: {
@@ -37,6 +37,29 @@ interface SecurityTokenRegistryContract extends GenericContract {
   };
 }
 
+export interface TickerDetails {
+  /**
+   * Owner
+   */
+  0: string;
+  /**
+   * Registration Date
+   */
+  1: string;
+  /**
+   * Expiry Date
+   */
+  2: string;
+  /**
+   * Name
+   */
+  3: string;
+  /**
+   * Registration status
+   */
+  4: boolean;
+}
+
 export class SecurityTokenRegistry extends Contract<
   SecurityTokenRegistryContract
 > {
@@ -56,9 +79,7 @@ export class SecurityTokenRegistry extends Contract<
   };
 
   public getTickerDetails = async ({ ticker }: GetTickerDetailsArgs) => {
-    const details = await this.contract.methods
-      .getTickerDetails(ticker)
-      .call({ from: this.context.account });
+    const details = await this.contract.methods.getTickerDetails(ticker).call();
 
     return details;
   };
@@ -78,7 +99,7 @@ export class SecurityTokenRegistry extends Contract<
         4: status,
       } = await this.getTickerDetails({ ticker });
       const intExpiryDate = parseInt(expiryDate);
-      if (owner !== '0x0000000000000000000000000000000000000000') {
+      if (owner !== ZERO_ADDRESS) {
         if (Date.now() > intExpiryDate * 1000 && !status) {
           return true;
         }

src/LowLevel/constants.ts

@@ -0,0 +1,3 @@
+const ZERO_ADDRESS: string = '0x0000000000000000000000000000000000000000';
+
+export { ZERO_ADDRESS };

src/LowLevel/types.ts

@@ -237,14 +237,6 @@ export interface IsTickerAvailableArgs {
   ticker: string;
 }
 
-export interface TickerDetails {
-  0: string; // Owner
-  1: string; // Registration Date
-  2: string; // Expiry Date
-  3: string; // Name
-  4: boolean; // Registration status
-}
-
 export enum NetworkIds {
   Local = 15,
   LocalVm = 16,

src/PolymathError.ts

@@ -9,7 +9,8 @@ export const ErrorMessagesPerCode: {
     'The wallet is locked, if Metamask extension is being used, the user needs to unlock it first',
   [ErrorCodes.UserDeniedAccess]: 'The user denied access',
   [ErrorCodes.TransactionRejectedByUser]: 'The user rejected the transaction',
-  [ErrorCodes.UnexpectedReturnData]: 'Unexpected return data',
+  [ErrorCodes.UnexpectedReturnData]:
+    'The data returned by the smart contract has an unexpected format. Please report this issue to the Polymath team',
 };
 
 export class PolymathError extends Error {