fix: convert transaction parameters properly

Author: ross-rosario

src/LowLevel/GeneralPermissionManager.ts

@@ -2,7 +2,7 @@ import { TransactionObject } from 'web3/eth/types';
 import { GeneralPermissionManagerAbi } from './abis/GeneralPermissionManagerAbi';
 import { Contract } from './Contract';
 import { Context } from './LowLevel';
-import { isAddress, getOptions } from './utils';
+import { isAddress, getOptions, fromAscii } from './utils';
 
 import {
   GenericContract,
@@ -51,7 +51,7 @@ export class GeneralPermissionManager extends Contract<GeneralPermissionManagerC
         message: `Delegate address is invalid: $delegate = ${delegate}`,
       });
 
-    const method = this.contract.methods.addDelegate(delegate, details);
+    const method = this.contract.methods.addDelegate(delegate, fromAscii(details));
     const options = await getOptions(method, { from: this.context.account });
     return () => method.send(options);
   };
@@ -63,7 +63,12 @@ export class GeneralPermissionManager extends Contract<GeneralPermissionManagerC
         message: `Delegate address is invalid: $delegate = ${delegate}`,
       });
 
-    const method = this.contract.methods.changePermission(delegate, module, perm, isGranted);
+    const method = this.contract.methods.changePermission(
+      delegate,
+      module,
+      fromAscii(perm),
+      isGranted
+    );
     const options = await getOptions(method, { from: this.context.account });
     return () => method.send(options);
   };

src/LowLevel/SecurityToken.ts

@@ -117,7 +117,7 @@ export class SecurityToken extends Contract<SecurityTokenContract> {
     return () => method.send(options);
   };
 
-  public addPermissionModule = async () => {
+  public addGeneralPermissionManager = async () => {
     const factoryAddress = await this.context.moduleRegistry.getModuleFactoryAddress({
       moduleName: 'GeneralPermissionManager',
       moduleType: ModuleTypes.Permission,

src/LowLevel/utils.ts

@@ -62,6 +62,14 @@ export function toAscii(value: string) {
   return utils.toAscii(value).replace(/\u0000/g, '');
 }
 
+export function fromAscii(value: string) {
+  return utils.fromAscii(value);
+}
+
+export function toChecksumAddress(value: string) {
+  return utils.toChecksumAddress(value);
+}
+
 export function isAddress(value: string) {
   return utils.isAddress(value);
 }

src/Polymath.ts

@@ -47,6 +47,7 @@ import { DividendsModule } from './entities/DividendsModule';
 import { StoModule } from './entities/StoModule';
 import { PolymathError } from './PolymathError';
 import { ChangeDelegatePermission } from './procedures/ChangeDelegatePermission';
+import { EnableGeneralPermissionManager } from './procedures/EnablePermissionModule';
 
 // TODO @RafaelVidaurre: Type this correctly. It should return a contextualized
 // version of T
@@ -211,6 +212,22 @@ export class Polymath {
     return await procedure.prepare();
   };
 
+  /**
+   * Enable General Permission Manager module
+   *
+   * @param securityTokenId token uuid
+   */
+  public enablePermissionsModule = async (args: { securityTokenId: string }) => {
+    const { symbol } = this.SecurityToken.unserialize(args.securityTokenId);
+    const procedure = new EnableGeneralPermissionManager(
+      {
+        symbol,
+      },
+      this.context
+    );
+    return await procedure.prepare();
+  };
+
   /**
    * Create investor supply checkpoint at the current date
    */

src/procedures/ChangeDelegatePermission.ts

@@ -8,12 +8,14 @@ import {
   ModulePermissions,
 } from '../types';
 import { PolymathError } from '../PolymathError';
+import { toChecksumAddress } from '../LowLevel/utils';
 
 export class ChangeDelegatePermission extends Procedure<ChangeDelegatePermissionArgs> {
   public type = ProcedureTypes.ChangeDelegatePermission;
 
   public async prepareTransactions() {
-    const { symbol, delegate, op, isGranted, details } = this.args;
+    const { symbol, op, isGranted, details } = this.args;
+    const delegate = toChecksumAddress(this.args.delegate);
     const { securityTokenRegistry } = this.context;
     let module: string;
     let perm: string;
@@ -53,6 +55,7 @@ export class ChangeDelegatePermission extends Procedure<ChangeDelegatePermission
       });
 
     const delegates = await permissionModule.getAllDelegates();
+    console.log(delegates);
     const exists = delegates.filter(element => element === delegate).length > 0;
 
     // In the following block we attempt to:

src/procedures/EnableGeneralPermissionManager.ts

@@ -0,0 +1,25 @@
+import { Procedure } from './Procedure';
+import {
+  ProcedureTypes,
+  PolyTransactionTags,
+  EnableGeneralPermissionManagerProcedureArgs,
+} from '../types';
+
+export class EnableGeneralPermissionManager extends Procedure<
+  EnableGeneralPermissionManagerProcedureArgs
+> {
+  public type = ProcedureTypes.EnableGeneralPermissionManager;
+
+  public async prepareTransactions() {
+    const { symbol } = this.args;
+    const { securityTokenRegistry } = this.context;
+
+    const securityToken = await securityTokenRegistry.getSecurityToken({
+      ticker: symbol,
+    });
+
+    await this.addTransaction(securityToken.addGeneralPermissionManager, {
+      tag: PolyTransactionTags.EnableGeneralPermissionManager,
+    })();
+  }
+}

src/procedures/EnablePermissionModule.ts

@@ -1,8 +1,14 @@
 import { Procedure } from './Procedure';
-import { ProcedureTypes, PolyTransactionTags, EnablePermissionModuleProcedureArgs } from '../types';
+import {
+  ProcedureTypes,
+  PolyTransactionTags,
+  EnableGeneralPermissionManagerProcedureArgs,
+} from '../types';
 
-export class EnablePermissionModule extends Procedure<EnablePermissionModuleProcedureArgs> {
-  public type = ProcedureTypes.EnablePermissionModule;
+export class EnableGeneralPermissionManager extends Procedure<
+  EnableGeneralPermissionManagerProcedureArgs
+> {
+  public type = ProcedureTypes.EnableGeneralPermissionManager;
 
   public async prepareTransactions() {
     const { symbol } = this.args;
@@ -12,8 +18,8 @@ export class EnablePermissionModule extends Procedure<EnablePermissionModuleProc
       ticker: symbol,
     });
 
-    await this.addTransaction(securityToken.addPermissionModule, {
-      tag: PolyTransactionTags.EnablePermissionModule,
+    await this.addTransaction(securityToken.addGeneralPermissionManager, {
+      tag: PolyTransactionTags.EnableGeneralPermissionManager,
     })();
   }
 }

src/types/index.ts

@@ -104,7 +104,7 @@ export enum ProcedureTypes {
   Approve = 'Approve',
   CreateCheckpoint = 'CreateCheckpoint',
   EnableDividendModules = 'EnableDividendModules',
-  EnablePermissionModule = 'EnablePermissionModule',
+  EnableGeneralPermissionManager = 'EnableGeneralPermissionManager',
   CreateErc20DividendDistribution = 'CreateErc20DividendDistribution',
   CreateEtherDividendDistribution = 'CreateEtherDividendDistribution',
   CreateSecurityToken = 'CreateSecurityToken',
@@ -129,7 +129,7 @@ export enum PolyTransactionTags {
   SetErc20TaxWithholding = 'SetErc20TaxWithholding',
   SetEtherTaxWithholding = 'SetEtherTaxWithholding',
   EnableDividends = 'EnableDividends',
-  EnablePermissionModule = 'EnablePermissionModule',
+  EnableGeneralPermissionManager = 'EnableGeneralPermissionManager',
   ReclaimDividendFunds = 'ReclaimDividendFunds',
   WithdrawTaxWithholdings = 'WithdrawTaxWithholdings',
   PushDividendPayment = 'PushDividendPayment',
@@ -215,7 +215,7 @@ export interface EnableDividendModulesProcedureArgs {
   types?: DividendModuleTypes[];
 }
 
-export interface EnablePermissionModuleProcedureArgs {
+export interface EnableGeneralPermissionManagerProcedureArgs {
   symbol: string;
 }
 
@@ -253,7 +253,7 @@ export interface SetDividendsWalletProcedureArgs {
 export interface ChangeDelegatePermissionArgs {
   symbol: string;
   delegate: string;
-  op: string;
+  op: ModuleOperations;
   isGranted: boolean;
   details?: string;
 }

src/utils/index.ts

@@ -1,6 +1,6 @@
+import stringify from 'json-stable-stringify';
 import { isAddress } from '../LowLevel/utils';
 import { Pojo } from '../types';
-import stringify from 'json-stable-stringify';
 
 export const delay = async (amount: number) => {
   return new Promise(resolve => {