Skip to content

Feature/cstackex 88 - Storage Pool operation code changes and UTs #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
piyush5netapp wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Feature/cstackex 88 - Storage Pool operation code changes and UTs #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ebb8be
Updated code for storage pool
Feb 3, 2026
a8f4d34
Updated code for storage pool 1
Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 35 additions & 2 deletions .../volume/ontap/src/main/java/org/apache/cloudstack/storage/service/UnifiedNASStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,8 +189,41 @@ public AccessGroup updateAccessGroup(AccessGroup accessGroup) {

@Override
public AccessGroup getAccessGroup(AccessGroup accessGroup) {
//TODO
return null;
s_logger.info("getAccessGroup: Get export policy");
Copy link

@rajiv-jain-netapp rajiv-jain-netapp Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you clarify why these code changes were included as part of the unit test task? Was there a pending merge that necessitated this update?


if (accessGroup == null) {
throw new CloudRuntimeException("getAccessGroup: Invalid accessGroup object - accessGroup is null");
}

// Get PrimaryDataStoreInfo from accessGroup
PrimaryDataStoreInfo primaryDataStoreInfo = accessGroup.getPrimaryDataStoreInfo();
if (primaryDataStoreInfo == null) {
throw new CloudRuntimeException("getAccessGroup: PrimaryDataStoreInfo is null in accessGroup");
}
s_logger.info("getAccessGroup: Get export policy for the storage pool {}", primaryDataStoreInfo.getName());
try {
String authHeader = Utility.generateAuthHeader(storage.getUsername(), storage.getPassword());
// Determine export policy attached to the storage pool
String exportPolicyName = primaryDataStoreInfo.getDetails().get(Constants.EXPORT_POLICY_NAME);
String exportPolicyId = primaryDataStoreInfo.getDetails().get(Constants.EXPORT_POLICY_ID);

try {
ExportPolicy exportPolicy = nasFeignClient.getExportPolicyById(authHeader,exportPolicyId);
if(exportPolicy==null){
s_logger.error("getAccessGroup: Failed to retrieve export policy for export policy");
throw new CloudRuntimeException("getAccessGroup: Failed to retrieve export policy for export policy");
}
accessGroup.setPolicy(exportPolicy);
s_logger.info("getAccessGroup: Successfully fetched export policy '{}'", exportPolicyName);
} catch (Exception e) {
s_logger.error("getAccessGroup: Failed to delete export policy. Exception: {}", e.getMessage(), e);
throw new CloudRuntimeException("Failed to delete export policy: " + e.getMessage(), e);
}
} catch (Exception e) {
s_logger.error("getAccessGroup: Failed to delete export policy. Exception: {}", e.getMessage(), e);
throw new CloudRuntimeException("Failed to delete export policy: " + e.getMessage(), e);
}
return accessGroup;
}

@Override
Expand Down
Loading
Loading