feat: build flag to append generated suffix to bundles#5814
Merged
NathanWalker merged 2 commits intoNativeScript:mainfrom Dec 27, 2024
Merged
feat: build flag to append generated suffix to bundles#5814NathanWalker merged 2 commits intoNativeScript:mainfrom
NathanWalker merged 2 commits intoNativeScript:mainfrom
Conversation
5 tasks
NathanWalker
approved these changes
Dec 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
See discussion: https://discord.com/channels/603595811204366337/1276116878154268763
It seems to be the case that sometimes when an iOS app is updating it does not overwrite the old js files with the new versions, resulting in app crashes etc.
What is the new behaviour?
This adds a new flag
--unique-bundlewhich instructs the cli to generate an id, which is then passed to webpack to be appended as a suffix to generated bundle names.The cli then uses this id to set the main entry in the package.json in the resulting app.
Note: In the discussion linked to above the files are generated with hashes, but then it becomes complicated to find the correct name of the main entry and I believe more brittle. An option would be to use something like the
webpack-manifest-pluginto find the hashed value, or just assume a pattern but this seems a more straightforward solution.There is a corresponding
@nativescript/webpackPR #10614