Closed
Conversation
Member
|
👍 |
2 similar comments
Contributor
|
👍 |
Contributor
|
👍 |
17 tasks
| } | ||
| // If skipLibCheck is enabled, skip type checking if file is a declaration file. | ||
| // If skipDefaultLibCheck is enabled, skip type checking if file contains a | ||
| // '/// <reference no-default-lib="true"/>' directive. |
Contributor
There was a problem hiding this comment.
Curious why we would skip for noDefaultLib. Is this to support just test harnesses or actual user code? 🌹
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new
--skipLibCheckcompiler option that causes type checking of declaration files (files with extension.d.ts) to be skipped. When a program includes large declaration files, the compiler spends a lot of time type checking declarations that are already known to not contain errors, and compile times may be significantly shortened by skipping declaration file type checks.Since declarations in one file can affect type checking in other files, some errors may not be detected when
--skipLibCheckis specified. For example, if a non-declaration file augments a type declared in a declaration file, errors may result that are only reported when the declaration file is checked. However, in practice such situations are rare.Fixes #8521. Compile times for the example given in this issue are reduced 5x.