COMP: Extend Pixi-Cxx post-build cleanup to MSVC artifacts (followup #6322)#6324
Merged
hjmjohnson merged 1 commit intoMay 22, 2026
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
7e884f1 to
0d54a70
Compare
458fce1 to
57b7dbb
Compare
Member
Author
|
ITK.Linux failures fixed in #6325 (dashboard files deleting mesh .obj files). |
dzenanz
reviewed
May 22, 2026
57b7dbb to
5c7262a
Compare
Member
Author
Member
|
PR 6235 is about ingestion, you must have meant some other PR, maybe #6325? |
Member
Author
Delete Windows compiler intermediates (*.obj, *.lib) in the post-build "Free disk space" step so windows-2022 gets the same disk recovery as Linux and macOS, and run `ccache --evict-older-than 1d` before `--cleanup` to match the eviction policy introduced for dashboard clients in InsightSoftwareConsortium#6322. Scope the deletion by path: *.obj also names Wavefront mesh fixtures (ITKIOMeshOBJ, Cuberille) and *.lib names a DCMTK Makefile template, so match compiled objects only under CMakeFiles/ and archives only under lib/ to avoid removing test data before the test phase. Follow-up to InsightSoftwareConsortium#6322; that PR moved equivalent logic into itk_common.cmake for clients that drive CTest via dashboard scripts. The Pixi workflow runs cmake + ctest directly and so needs its own inline cleanup.
5c7262a to
0643ff5
Compare
dzenanz
approved these changes
May 22, 2026
Member
Author
|
windows build failure is a flake on downloading external data unrelated to this PR. |
7505c13
into
InsightSoftwareConsortium:main
15 of 18 checks passed
This was referenced May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #6322 (merged): widens the Pixi-Cxx workflow's post-build cleanup to also delete MSVC
*.obj/*.libartifacts and runsccache --evict-older-than 1dbefore--cleanupso the windows-2022 runner gets the same disk relief that #6322 gave dashboard-script clients viaitk_common.cmake.Why a separate workflow change is needed
PR #6322 added the equivalent
*.o/*.acleanup toitk_common.cmakebetweenctest_buildandctest_test. That helps Azure DevOps / CircleCI / custom nightly clients that drive CTest viactest -S dashboard.cmake.The
ITK.Pixiworkflow runs cmake + ctest directly (no dashboard script —pixi run configure-cithencmake --build buildthenctest -j3 --test-dir build), so it does not pick up theitk_common.cmakecleanup hook. It has its own inline "Free disk space after build" step that already handled POSIX object files. This PR widens that step to also cover Windows MSVC artifacts and adds the older-than-1d ccache eviction that #6322 introduced for dashboard clients.Diff