fix: encode serialized JSON string as UTF-8#121
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #121 +/- ##
==========================================
+ Coverage 99.01% 99.50% +0.48%
==========================================
Files 22 22
Lines 816 815 -1
==========================================
+ Hits 808 811 +3
+ Misses 8 4 -4
Continue to review full report at Codecov.
|
pyrooka
commented
Aug 17, 2021
Comment on lines
-376
to
+375
| if sys.version_info >= (3, 0) and isinstance(data, str): | ||
| if isinstance(data, str): |
Member
Author
There was a problem hiding this comment.
We don't support Python 2 as far as I know, so I removed this version check.
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Aug 18, 2021
## [3.11.1](v3.11.0...v3.11.1) (2021-08-18) ### Bug Fixes * encode serialized JSON string as UTF-8 ([#121](#121)) ([6c1ddac](6c1ddac))
|
🎉 This PR is included in version 3.11.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds encoding to the serialized JSON payload. We are already doing this if the payload is passed as a string.
In the generated SDKs, for example in the Platform Services/Case Management, we serialize the
datadictionary and pass it to theprepare_requestfunction as a string, therefore I think it's safe to add encoding here.