feat: implement container authentication#119
Merged
Conversation
More info:
- Surround top-level function and class definitions with two blank
lines: https://www.python.org/dev/peps/pep-0008/#blank-lines
- Imports grouping and ordering:
https://www.python.org/dev/peps/pep-0008/#imports
Codecov Report
@@ Coverage Diff @@
## main #119 +/- ##
==========================================
+ Coverage 98.92% 99.01% +0.09%
==========================================
Files 20 22 +2
Lines 746 816 +70
==========================================
+ Hits 738 808 +70
Misses 8 8
Continue to review full report at Codecov.
|
Contributor
|
@pyrooka Looks like there's a linter error in the builds :) |
pyrooka
commented
Aug 9, 2021
padamstx
suggested changes
Aug 9, 2021
dpopp07
reviewed
Aug 10, 2021
dpopp07
left a comment
dpopp07
left a comment
There was a problem hiding this comment.
Looks good once Phil's comments are addressed (I'll wait until then to officially approve)
I just found what I think are a few typos
pyrooka
force-pushed
the
add-container-authenticator
branch
from
f17b94d to
60f49f2
Compare
pyrooka
force-pushed
the
add-container-authenticator
branch
from
1cf9817 to
fce4dd1
Compare
padamstx
suggested changes
Aug 11, 2021
Contributor
padamstx
left a comment
padamstx
left a comment
There was a problem hiding this comment.
Getting pretty close, but a few small changes needed.
Plus I'm sneaking in a request to support "AUTHTYPE" as an alias for the "AUTH_TYPE" config property :)
padamstx
approved these changes
Aug 11, 2021
Member
Author
|
Thank you for fixing these issues @padamstx ! |
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Aug 12, 2021
# [3.11.0](v3.10.1...v3.11.0) (2021-08-12) ### Features * implement container authentication ([#119](#119)) ([5237277](5237277))
|
🎉 This PR is included in version 3.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the new container authentication flow, which is highly based on the IAM auth. This means a new token manager and authenticator have been created and covered with tests.
NOTE: this PR/branch is based on the IAM refactoring branch(shared-iam-related-code)/PR(#118), so SHOULD NOT be merged in before the other one.