Remove undocumented feature for overriding the http method via header and related cleanup#3040
Merged
Conversation
lmsurpre
commented
Nov 24, 2021
| public void setCharacterEncoding(String arg0) throws UnsupportedEncodingException { | ||
| delegate.setCharacterEncoding(arg0); | ||
| @SuppressWarnings("unused") | ||
| private String displayHeaderValues(Enumeration<String> headers) { |
Member
Author
There was a problem hiding this comment.
this was there before, i just added the javadoc for it. i think we could probably axe this one as well.
lmsurpre
commented
Nov 24, 2021
| private String updateAcceptHeader(String s) { | ||
| if (s!= null && !s.contains(CHARSET)) { | ||
| String originalHeaderValue = delegate.getHeader(ACCEPT); | ||
| String originalHeaderValue = delegate.getHeader(HttpHeaders.ACCEPT); |
Member
Author
There was a problem hiding this comment.
Suggested change
| String originalHeaderValue = delegate.getHeader(HttpHeaders.ACCEPT); | |
| String originalHeaderValue = delegate.getHeader(ACCEPT); |
Member
Author
There was a problem hiding this comment.
forgot to clean this up after adding static import
1. We had an undocumented / untested feature where you can override the HTTP method via a header. This changeset removes that. CXF has a slightly different header for doing exactly the same thing. Not sure about RESTEasy. 2. We had a whole lot of unnecessary override methods in FHIRHttpServletRequestWrapper. Since the parent class defaults to calling the delegate already, its cleaner to leave those out of this subclass. 3. Committing minor edits to the JAX-RS Search resource...it doesn't actually consume APPLICATION_FHIR media types in any of the methods and there's no need to override the class-level path with the same value Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
changed the title
lmsurpre
added
the
removal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had an undocumented / untested feature where you can override the
HTTP method via a header. This changeset removes that. CXF has a
slightly different header for doing exactly the same thing. Not sure
about RESTEasy.
We had a whole lot of unnecessary override methods in
FHIRHttpServletRequestWrapper. Since the parent class defaults to
calling the delegate already, its cleaner to leave those out of this
subclass.
Committing minor edits to the JAX-RS Search resource...it doesn't
actually consume APPLICATION_FHIR media types in any of the methods and
there's no need to override the class-level path with the same value
Signed-off-by: Lee Surprenant lmsurpre@us.ibm.com