Remove jwt lib dependency#2833
Merged
Merged
Conversation
lmsurpre
force-pushed
the
remove-jwt-lib-dependency
branch
from
c0ccd3c to
ed585f6
Compare
We use such a small portion of this library that I was always on the fence about whether we should even bother with it. Recently, a user hit some issues with conflicting jackson dependency versions and so I decided to see what fhir-smart might look like without this dependency. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
force-pushed
the
remove-jwt-lib-dependency
branch
from
ed585f6 to
9114085
Compare
prb112
reviewed
Oct 6, 2021
lmsurpre
commented
Oct 6, 2021
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
prb112
approved these changes
Oct 6, 2021
Contributor
prb112
left a comment
prb112
left a comment
There was a problem hiding this comment.
LGTM - discussed with Lee
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use such a small portion of this library that I was always on the
fence about whether we should even bother with it.
Recently, a user hit some issues with conflicting jackson dependency
versions and so I decided to see what fhir-smart might look like without
this dependency.