-
Notifications
You must be signed in to change notification settings - Fork 403
Add "no normalization performed" test for Storage client. #933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
49 changes: 49 additions & 0 deletions
49
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.IntegrationTests/NormalizationTest.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| // Copyright 2017 Google Inc. All Rights Reserved. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| using System.IO; | ||
| using System.Text; | ||
| using Xunit; | ||
|
|
||
| namespace Google.Cloud.Storage.V1.IntegrationTests | ||
| { | ||
| /// <summary> | ||
| /// Tests that ensure the client does *not* perform any normalization. | ||
| /// The bucket <see cref="s_bucket"/> contains two files, which are both named "Café" | ||
| /// but using different normalization. The client should be able to retrieve both. | ||
| /// </summary> | ||
| public class NormalizationTest | ||
| { | ||
| private const string s_bucket = "storage-library-test-bucket"; | ||
|
|
||
| [Theory] | ||
| // Normalization Form C: a single character for e-acute. | ||
| // URL should end with Cafe%CC%81 | ||
| [InlineData("Caf\u00e9", "Normalization Form C")] | ||
| // Normalization Form D: an ASCII e followed by U+0301 combining character | ||
| // URL should end with Caf%C3%A9 | ||
| [InlineData("Cafe\u0301", "Normalization Form D")] | ||
| public void FetchObjectAndCheckContent(string name, string expectedContent) | ||
| { | ||
| var client = StorageClient.Create(); | ||
| var obj = client.GetObject(s_bucket, name); | ||
| Assert.Equal(name, obj.Name); | ||
|
|
||
| var stream = new MemoryStream(); | ||
| client.DownloadObject(s_bucket, name, stream); | ||
| string text = Encoding.UTF8.GetString(stream.ToArray()); | ||
| Assert.Equal(expectedContent, text); | ||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.