Skip to content

infra: Fix keep-alive - #8106

Merged
khvn26 merged 1 commit into
mainfrom
fix/gunicorn-keepalive-alb-502
Jul 27, 2026
Merged

infra: Fix keep-alive#8106
khvn26 merged 1 commit into
mainfrom
fix/gunicorn-keepalive-alb-502

Conversation

@khvn26

@khvn26 khvn26 commented Jul 27, 2026

Copy link
Copy Markdown
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

In this PR, we establish a keep-alive TTL slightly higher than ALB's to avoid ALB reusing a keep-alive socket that Gunicorn had already closed.

How did you test this code?

Will test on prod.

@khvn26
khvn26 requested a review from a team as a code owner July 27, 2026 09:30
@khvn26
khvn26 requested review from gagantrivedi and removed request for a team July 27, 2026 09:30
@vercel

vercel Bot commented Jul 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Jul 27, 2026 9:30am
flagsmith-frontend-preview Ignored Ignored Jul 27, 2026 9:30am
flagsmith-frontend-staging Ignored Ignored Jul 27, 2026 9:30am

Request Review

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 32839734-bf29-45c7-9ea2-13d781bd007a

📥 Commits

Reviewing files that changed from the base of the PR and between c174d2e and c70fe99.

📒 Files selected for processing (4)
  • infrastructure/aws/production/ecs-task-definition-admin-api.json
  • infrastructure/aws/production/ecs-task-definition-sdk-api.json
  • infrastructure/aws/staging/ecs-task-definition-admin-api.json
  • infrastructure/aws/staging/ecs-task-definition-sdk-api.json

📝 Walkthrough

Walkthrough

The production and staging ECS task definitions for the admin and SDK APIs update the flagsmith-api container command from serve to serve --keep-alive 75.

Estimated code review effort: 1 (Trivial) | ~5 minutes


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@khvn26
khvn26 merged commit 96f54b8 into main Jul 27, 2026
12 checks passed
@khvn26
khvn26 deleted the fix/gunicorn-keepalive-alb-502 branch July 27, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants