feat(experimentation): enable Firehose CloudWatch error logging - #8068
Conversation
Create a per-organisation CloudWatch log group and stream and enable CloudWatchLoggingOptions on the delivery stream so Firehose delivery failures are logged; remove them on teardown.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
📝 WalkthroughWalkthroughFirehose ingestion infrastructure now provisions a per-organisation CloudWatch Logs group and Estimated code review effort: 2 (Simple) | ~15 minutes Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Docker builds report
|
There was a problem hiding this comment.
Actionable comments posted: 3
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: cef87322-9fcd-4d22-a42a-213775e9c26d
📒 Files selected for processing (3)
api/experimentation/ingestion_infra_service.pyapi/tests/unit/experimentation/test_ingestion_infra_service.pydocs/docs/deployment-self-hosting/observability/_events-catalogue.md
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #18618 (attempt 2)Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
🗂️ Previous results❌ private-cloud · depot-ubuntu-latest-arm-16 — run #18618 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
Failed testsfirefox › tests/environment-permission-test.pw.ts › Environment Permission Tests › Environment-level permissions control access to features, identities, and segments @enterprise ✅ private-cloud · depot-ubuntu-latest-16 — run #18618 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
✅ oss · depot-ubuntu-latest-16 — run #18618 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-16)Details
✅ oss · depot-ubuntu-latest-arm-16 — run #18618 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
|
Visual Regression19 screenshots compared. See report for details. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8068 +/- ##
=======================================
Coverage 98.66% 98.66%
=======================================
Files 1517 1517
Lines 60318 60363 +45
=======================================
+ Hits 59512 59557 +45
Misses 806 806 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Enables Amazon Data Firehose CloudWatch error logging on the per-organisation delivery streams, as AWS recommends, so delivery failures are diagnosable.
/aws/kinesisfirehose/events-ingestion-org-{id}) andDestinationDeliverylog stream when provisioning, and removes them on teardown.CloudWatchLoggingOptionson the Firehose delivery stream's S3 destination.Depends on matching Pulumi IAM changes: the Firehose delivery role needs
logs:PutLogEvents, and the task-processor role needslogs:CreateLogGroup/CreateLogStream/DeleteLogGroupon/aws/kinesisfirehose/events-ingestion-org-*(separate Pulumi PR).How did you test this code?
Unit tests (moto): assert the log group +
DestinationDeliverystream are created,CloudWatchLoggingOptionsis set on the delivery stream, and both are removed on teardown.experimentation.ingestion_infra_serviceremains at 100% coverage.