From 1c8a281803475d4f1ef0ab10b075d3b3ec145b27 Mon Sep 17 00:00:00 2001 From: Marc Glasser Date: Mon, 20 Apr 2026 13:00:24 -1000 Subject: [PATCH 1/2] add Daily label to deploy checklist at creation to prevent MelvinBot Monthly misclassification --- .github/libs/CONST.ts | 1 + scripts/createOrUpdateDeployChecklist.ts | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/libs/CONST.ts b/.github/libs/CONST.ts index 4a6b95d9b022..2c95f3da887a 100644 --- a/.github/libs/CONST.ts +++ b/.github/libs/CONST.ts @@ -18,6 +18,7 @@ const CONST = { INTERNAL_QA: 'InternalQA', HELP_WANTED: 'Help Wanted', CP_STAGING: 'CP Staging', + DAILY: 'Daily', }, STATE: { OPEN: 'open', diff --git a/scripts/createOrUpdateDeployChecklist.ts b/scripts/createOrUpdateDeployChecklist.ts index 710f1b4a6d71..dc91a84345a0 100644 --- a/scripts/createOrUpdateDeployChecklist.ts +++ b/scripts/createOrUpdateDeployChecklist.ts @@ -314,7 +314,7 @@ async function run(): Promise { const {data: newChecklist} = await GithubUtils.octokit.issues.create({ ...defaultPayload, title: `Deploy Checklist: New Expensify ${format(new Date(), CONST.DATE_FORMAT_STRING)}`, - labels: [CONST.LABELS.STAGING_DEPLOY, CONST.LABELS.LOCK_DEPLOY], + labels: [CONST.LABELS.STAGING_DEPLOY, CONST.LABELS.LOCK_DEPLOY, CONST.LABELS.DAILY], assignees: [CONST.APPLAUSE_BOT as string].concat(checklistAssignees), }); console.log(`Successfully created new deploy checklist! 🎉 ${newChecklist.html_url}`); From b967fc71e7db66ac066929337f7cac7eff1f3dbd Mon Sep 17 00:00:00 2001 From: Marc Glasser Date: Mon, 20 Apr 2026 13:29:20 -1000 Subject: [PATCH 2/2] update deploy checklist tests to expect Daily label --- tests/unit/createOrUpdateDeployChecklistTest.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/unit/createOrUpdateDeployChecklistTest.ts b/tests/unit/createOrUpdateDeployChecklistTest.ts index 9b4e7366746c..94e0200a80dc 100644 --- a/tests/unit/createOrUpdateDeployChecklistTest.ts +++ b/tests/unit/createOrUpdateDeployChecklistTest.ts @@ -266,7 +266,7 @@ describe('createOrUpdateDeployChecklist', () => { owner: CONST.GITHUB_OWNER, repo: CONST.APP_REPO, title: `Deploy Checklist: New Expensify ${fns.format(new Date(), 'yyyy-MM-dd')}`, - labels: [CONST.LABELS.STAGING_DEPLOY, CONST.LABELS.LOCK_DEPLOY], + labels: [CONST.LABELS.STAGING_DEPLOY, CONST.LABELS.LOCK_DEPLOY, CONST.LABELS.DAILY], html_url: `https://github.com/${process.env.GITHUB_REPOSITORY}/issues/29`, assignees: [CONST.APPLAUSE_BOT], body: @@ -317,7 +317,7 @@ describe('createOrUpdateDeployChecklist', () => { owner: CONST.GITHUB_OWNER, repo: CONST.APP_REPO, title: `Deploy Checklist: New Expensify ${fns.format(new Date(), 'yyyy-MM-dd')}`, - labels: [CONST.LABELS.STAGING_DEPLOY, CONST.LABELS.LOCK_DEPLOY], + labels: [CONST.LABELS.STAGING_DEPLOY, CONST.LABELS.LOCK_DEPLOY, CONST.LABELS.DAILY], html_url: `https://github.com/${process.env.GITHUB_REPOSITORY}/issues/29`, assignees: [CONST.APPLAUSE_BOT], body: