From 405783cf50a4e28ecd224c6a88b88864c0383c51 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marco=20Ch=C3=A1vez?= Date: Thu, 24 Feb 2022 14:09:26 -0600 Subject: [PATCH 01/12] Update PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index ced5e86b0ed6..63e2374ae74d 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -41,7 +41,13 @@ This is a checklist for PR authors & reviewers. Please make sure to complete all - [ ] I wrote clear testing steps that cover the changes made in this PR - [ ] I clearly indicated the environment tests should be run in (Staging vs Production) - [ ] I wrote testing steps that cover success & fail scenarios (if applicable) -- [ ] I ran the tests & they passed on **all platforms** +- [ ] I ran the tests & veryfy they passed on: + - [ ] iOS / native + - [ ] Android / native + - [ ] iOS / Safari + - [ ] Android / Chrome + - [ ] OSX / Chrome + - [ ] OSX / Desktop - [ ] I included screenshots or videos for tests on [all platforms](https://github.com/Expensify/App/blob/main/CONTRIBUTING.md#make-sure-you-can-test-on-all-platforms) - [ ] I verified there are no console errors related to changes in this PR - [ ] I followed proper code patterns (see [Reviewing the code](../PR_REVIEW_GUIDELINES.md#reviewing-the-code)) @@ -57,7 +63,13 @@ This is a checklist for PR authors & reviewers. Please make sure to complete all - [ ] I verified testing steps are clear and they cover the changes made in this PR - [ ] I verified the testing environment is mentioned in the test steps - [ ] I verified testing steps cover success & fail scenarios (if applicable) -- [ ] I verified tests pass on **all platforms** & I tested again on all platforms +- [ ] I verified tests pass on **all platforms** & I tested again on: + - [ ] iOS / native + - [ ] Android / native + - [ ] iOS / Safari + - [ ] Android / Chrome + - [ ] OSX / Chrome + - [ ] OSX / Desktop - [ ] I checked that screenshots or videos are included for tests on [all platforms](https://github.com/Expensify/App/blob/main/CONTRIBUTING.md#make-sure-you-can-test-on-all-platforms) - [ ] I verified there are no console errors related to changes in this PR - [ ] I verified proper code patterns were followed (see [Reviewing the code](../PR_REVIEW_GUIDELINES.md#reviewing-the-code)) From e3467603a69dcfa7a98b7b0fe35c81e1ae660d00 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marco=20Ch=C3=A1vez?= Date: Thu, 24 Feb 2022 14:10:39 -0600 Subject: [PATCH 02/12] fix link to PR_REVIEW_GUIDELINES.md --- .github/PULL_REQUEST_TEMPLATE.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 63e2374ae74d..5d66227f79ec 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -50,12 +50,12 @@ This is a checklist for PR authors & reviewers. Please make sure to complete all - [ ] OSX / Desktop - [ ] I included screenshots or videos for tests on [all platforms](https://github.com/Expensify/App/blob/main/CONTRIBUTING.md#make-sure-you-can-test-on-all-platforms) - [ ] I verified there are no console errors related to changes in this PR -- [ ] I followed proper code patterns (see [Reviewing the code](../PR_REVIEW_GUIDELINES.md#reviewing-the-code)) +- [ ] I followed proper code patterns (see [Reviewing the code](https://github.com/Expensify/App/blob/main/PR_REVIEW_GUIDELINES.md#reviewing-the-code)) - [ ] I added comments when the code was not self explanatory - [ ] I put all copy / text shown in the product in all `src/languages/*` files (if applicable) - [ ] I followed proper naming convention for platform-specific files (if applicable) - [ ] I followed style guidelines (in [`Styling.md`](../STYLING.md)) for all style edits I made -- [ ] I followed the guidelines as stated in the [Review Guidelines](../PR_REVIEW_GUIDELINES.md) +- [ ] I followed the guidelines as stated in the [Review Guidelines](https://github.com/Expensify/App/blob/main/PR_REVIEW_GUIDELINES.md) #### PR Reviewer Checklist - [ ] I verified the Author pulled `main` before submitting the PR @@ -72,12 +72,12 @@ This is a checklist for PR authors & reviewers. Please make sure to complete all - [ ] OSX / Desktop - [ ] I checked that screenshots or videos are included for tests on [all platforms](https://github.com/Expensify/App/blob/main/CONTRIBUTING.md#make-sure-you-can-test-on-all-platforms) - [ ] I verified there are no console errors related to changes in this PR -- [ ] I verified proper code patterns were followed (see [Reviewing the code](../PR_REVIEW_GUIDELINES.md#reviewing-the-code)) +- [ ] I verified proper code patterns were followed (see [Reviewing the code](https://github.com/Expensify/App/blob/main/PR_REVIEW_GUIDELINES.md#reviewing-the-code)) - [ ] I verified comments were added when the code was not self explanatory - [ ] I verified any copy / text shown in the product was added in all `src/languages/*` files (if applicable) - [ ] I verified proper naming convention for platform-specific files was followed (if applicable) - [ ] I verified [style guidelines](../STYLING.md) were followed -- [ ] I verified that this PR follows the guidelines as stated in the [Review Guidelines](../PR_REVIEW_GUIDELINES.md) +- [ ] I verified that this PR follows the guidelines as stated in the [Review Guidelines](https://github.com/Expensify/App/blob/main/PR_REVIEW_GUIDELINES.md) ### QA Steps From 98af051c952d1fd30916b4755139be24f861f57c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marco=20Ch=C3=A1vez?= Date: Mon, 28 Feb 2022 18:04:29 -0600 Subject: [PATCH 05/12] Update PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 5c59ef970b29..0029bdf383b6 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -46,8 +46,8 @@ This is a checklist for PR authors & reviewers. Please make sure to complete all - [ ] Android / native - [ ] iOS / Safari - [ ] Android / Chrome - - [ ] OSX / Chrome - - [ ] OSX / Desktop + - [ ] MacOS / Chrome + - [ ] MacOS / Desktop - [ ] I included screenshots or videos for tests on [all platforms](https://github.com/Expensify/App/blob/main/CONTRIBUTING.md#make-sure-you-can-test-on-all-platforms) - [ ] I verified there are no console errors related to changes in this PR - [ ] I followed proper code patterns (see [Reviewing the code](https://github.com/Expensify/App/blob/main/PR_REVIEW_GUIDELINES.md#reviewing-the-code)) @@ -70,8 +70,8 @@ This is a checklist for PR authors & reviewers. Please make sure to complete all - [ ] Android / native - [ ] iOS / Safari - [ ] Android / Chrome - - [ ] OSX / Chrome - - [ ] OSX / Desktop + - [ ] MacOS / Chrome + - [ ] MacOS / Desktop - [ ] I checked that screenshots or videos are included for tests on [all platforms](https://github.com/Expensify/App/blob/main/CONTRIBUTING.md#make-sure-you-can-test-on-all-platforms) - [ ] I verified there are no console errors related to changes in this PR - [ ] I verified proper code patterns were followed (see [Reviewing the code](https://github.com/Expensify/App/blob/main/PR_REVIEW_GUIDELINES.md#reviewing-the-code)) From 81f34c5e1af1c832b629ec0026c7e98d2e33ed54 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marco=20Ch=C3=A1vez?= Date: Mon, 28 Feb 2022 18:08:08 -0600 Subject: [PATCH 06/12] Update PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 0029bdf383b6..e13378bbbada 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -56,7 +56,7 @@ This is a checklist for PR authors & reviewers. Please make sure to complete all - [ ] I followed proper naming convention for platform-specific files (if applicable) - [ ] I followed style guidelines (in [`Styling.md`](../STYLING.md)) for all style edits I made - [ ] I followed the guidelines as stated in the [Review Guidelines](https://github.com/Expensify/App/blob/main/PR_REVIEW_GUIDELINES.md) -- [ ] I tested other components that can be impacted by my changes +- [ ] I tested other components that can be impacted by my changes (i.e. if the PR modified a shared library or component like `Avatar`, I verify the components using `Avatar` are working as expected) - [ ] I corroborated the UI performance was not affected (the performance is the same than `main` branch) #### PR Reviewer Checklist @@ -80,7 +80,7 @@ This is a checklist for PR authors & reviewers. Please make sure to complete all - [ ] I verified proper naming convention for platform-specific files was followed (if applicable) - [ ] I verified [style guidelines](../STYLING.md) were followed - [ ] I verified that this PR follows the guidelines as stated in the [Review Guidelines](https://github.com/Expensify/App/blob/main/PR_REVIEW_GUIDELINES.md) -- [ ] I verified other components are not impacted by changes in this PR +- [ ] I verified other components are not impacted by changes in this PR (i.e. if the PR modifies a shared library or component like `Avatar`, I verify the components using `Avatar` are working as expected) - [ ] I verified the UI performance was not affected (the performance is the same than `main` branch) ### QA Steps From 68a0fcc795f4fef1a862f2fa8ffa5b9e615f1d60 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marco=20Ch=C3=A1vez?= Date: Mon, 28 Feb 2022 18:09:18 -0600 Subject: [PATCH 07/12] Update PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index e13378bbbada..dfb3521cd6e7 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -41,6 +41,7 @@ This is a checklist for PR authors & reviewers. Please make sure to complete all - [ ] I wrote clear testing steps that cover the changes made in this PR - [ ] I clearly indicated the environment tests should be run in (Staging vs Production) - [ ] I wrote testing steps that cover success & fail scenarios (if applicable) +- [ ] I included screenshots or videos for tests on [all platforms](https://github.com/Expensify/App/blob/main/CONTRIBUTING.md#make-sure-you-can-test-on-all-platforms) - [ ] I ran the tests & veryfy they passed on: - [ ] iOS / native - [ ] Android / native @@ -48,7 +49,6 @@ This is a checklist for PR authors & reviewers. Please make sure to complete all - [ ] Android / Chrome - [ ] MacOS / Chrome - [ ] MacOS / Desktop -- [ ] I included screenshots or videos for tests on [all platforms](https://github.com/Expensify/App/blob/main/CONTRIBUTING.md#make-sure-you-can-test-on-all-platforms) - [ ] I verified there are no console errors related to changes in this PR - [ ] I followed proper code patterns (see [Reviewing the code](https://github.com/Expensify/App/blob/main/PR_REVIEW_GUIDELINES.md#reviewing-the-code)) - [ ] I added comments when the code was not self explanatory @@ -65,6 +65,7 @@ This is a checklist for PR authors & reviewers. Please make sure to complete all - [ ] I verified testing steps are clear and they cover the changes made in this PR - [ ] I verified the testing environment is mentioned in the test steps - [ ] I verified testing steps cover success & fail scenarios (if applicable) +- [ ] I checked that screenshots or videos are included for tests on [all platforms](https://github.com/Expensify/App/blob/main/CONTRIBUTING.md#make-sure-you-can-test-on-all-platforms) - [ ] I verified tests pass on **all platforms** & I tested again on: - [ ] iOS / native - [ ] Android / native @@ -72,7 +73,6 @@ This is a checklist for PR authors & reviewers. Please make sure to complete all - [ ] Android / Chrome - [ ] MacOS / Chrome - [ ] MacOS / Desktop -- [ ] I checked that screenshots or videos are included for tests on [all platforms](https://github.com/Expensify/App/blob/main/CONTRIBUTING.md#make-sure-you-can-test-on-all-platforms) - [ ] I verified there are no console errors related to changes in this PR - [ ] I verified proper code patterns were followed (see [Reviewing the code](https://github.com/Expensify/App/blob/main/PR_REVIEW_GUIDELINES.md#reviewing-the-code)) - [ ] I verified comments were added when the code was not self explanatory From db1e75148fd87c237ec6bbefaedef70d21bf189e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marco=20Ch=C3=A1vez?= Date: Mon, 28 Feb 2022 18:14:26 -0600 Subject: [PATCH 08/12] Update PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index dfb3521cd6e7..e123d711f1d3 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -55,6 +55,7 @@ This is a checklist for PR authors & reviewers. Please make sure to complete all - [ ] I put all copy / text shown in the product in all `src/languages/*` files (if applicable) - [ ] I followed proper naming convention for platform-specific files (if applicable) - [ ] I followed style guidelines (in [`Styling.md`](../STYLING.md)) for all style edits I made + - [ ] I followed the JSDocs style guidelines (in [STYLE.md](https://github.com/Expensify/App/blob/main/STYLE.md#jsdocs)) - [ ] I followed the guidelines as stated in the [Review Guidelines](https://github.com/Expensify/App/blob/main/PR_REVIEW_GUIDELINES.md) - [ ] I tested other components that can be impacted by my changes (i.e. if the PR modified a shared library or component like `Avatar`, I verify the components using `Avatar` are working as expected) - [ ] I corroborated the UI performance was not affected (the performance is the same than `main` branch) @@ -79,6 +80,7 @@ This is a checklist for PR authors & reviewers. Please make sure to complete all - [ ] I verified any copy / text shown in the product was added in all `src/languages/*` files (if applicable) - [ ] I verified proper naming convention for platform-specific files was followed (if applicable) - [ ] I verified [style guidelines](../STYLING.md) were followed + - [ ] I verified the JSDocs style guidelines (in [STYLE.md](https://github.com/Expensify/App/blob/main/STYLE.md#jsdocs)) were followed - [ ] I verified that this PR follows the guidelines as stated in the [Review Guidelines](https://github.com/Expensify/App/blob/main/PR_REVIEW_GUIDELINES.md) - [ ] I verified other components are not impacted by changes in this PR (i.e. if the PR modifies a shared library or component like `Avatar`, I verify the components using `Avatar` are working as expected) - [ ] I verified the UI performance was not affected (the performance is the same than `main` branch) From 35ff279860bc722ab0ee58027cd3aa33fd13f211 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marco=20Ch=C3=A1vez?= Date: Mon, 28 Feb 2022 18:15:02 -0600 Subject: [PATCH 09/12] Update PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index e123d711f1d3..ae6ba6d6ae59 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -55,7 +55,7 @@ This is a checklist for PR authors & reviewers. Please make sure to complete all - [ ] I put all copy / text shown in the product in all `src/languages/*` files (if applicable) - [ ] I followed proper naming convention for platform-specific files (if applicable) - [ ] I followed style guidelines (in [`Styling.md`](../STYLING.md)) for all style edits I made - - [ ] I followed the JSDocs style guidelines (in [STYLE.md](https://github.com/Expensify/App/blob/main/STYLE.md#jsdocs)) + - [ ] I followed the JSDocs style guidelines (in [`STYLE.md`](https://github.com/Expensify/App/blob/main/STYLE.md#jsdocs)) - [ ] I followed the guidelines as stated in the [Review Guidelines](https://github.com/Expensify/App/blob/main/PR_REVIEW_GUIDELINES.md) - [ ] I tested other components that can be impacted by my changes (i.e. if the PR modified a shared library or component like `Avatar`, I verify the components using `Avatar` are working as expected) - [ ] I corroborated the UI performance was not affected (the performance is the same than `main` branch) @@ -80,7 +80,7 @@ This is a checklist for PR authors & reviewers. Please make sure to complete all - [ ] I verified any copy / text shown in the product was added in all `src/languages/*` files (if applicable) - [ ] I verified proper naming convention for platform-specific files was followed (if applicable) - [ ] I verified [style guidelines](../STYLING.md) were followed - - [ ] I verified the JSDocs style guidelines (in [STYLE.md](https://github.com/Expensify/App/blob/main/STYLE.md#jsdocs)) were followed + - [ ] I verified the JSDocs style guidelines (in [`STYLE.md`](https://github.com/Expensify/App/blob/main/STYLE.md#jsdocs)) were followed - [ ] I verified that this PR follows the guidelines as stated in the [Review Guidelines](https://github.com/Expensify/App/blob/main/PR_REVIEW_GUIDELINES.md) - [ ] I verified other components are not impacted by changes in this PR (i.e. if the PR modifies a shared library or component like `Avatar`, I verify the components using `Avatar` are working as expected) - [ ] I verified the UI performance was not affected (the performance is the same than `main` branch) From 01925f758573881cf81ea35b9774022636e8c4f6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marco=20Ch=C3=A1vez?= Date: Mon, 28 Feb 2022 18:30:29 -0600 Subject: [PATCH 10/12] Update PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index ae6ba6d6ae59..d47aca21b0d1 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -59,6 +59,7 @@ This is a checklist for PR authors & reviewers. Please make sure to complete all - [ ] I followed the guidelines as stated in the [Review Guidelines](https://github.com/Expensify/App/blob/main/PR_REVIEW_GUIDELINES.md) - [ ] I tested other components that can be impacted by my changes (i.e. if the PR modified a shared library or component like `Avatar`, I verify the components using `Avatar` are working as expected) - [ ] I corroborated the UI performance was not affected (the performance is the same than `main` branch) +- [ ] If I created a new component I verified a similar component doesn't exist in the codebase. #### PR Reviewer Checklist - [ ] I verified the Author pulled `main` before submitting the PR @@ -84,6 +85,8 @@ This is a checklist for PR authors & reviewers. Please make sure to complete all - [ ] I verified that this PR follows the guidelines as stated in the [Review Guidelines](https://github.com/Expensify/App/blob/main/PR_REVIEW_GUIDELINES.md) - [ ] I verified other components are not impacted by changes in this PR (i.e. if the PR modifies a shared library or component like `Avatar`, I verify the components using `Avatar` are working as expected) - [ ] I verified the UI performance was not affected (the performance is the same than `main` branch) +- [ ] If a new component is created I verified a similar component doesn't exist in the codebase. + ### QA Steps #### Contributor (PR Author) Checklist -- [ ] I made sure to pull `main` before submitting my PR for review +- [ ] I verified the PR has a small number of commits behind `main` - [ ] I linked the correct issue in the `### Fixed Issues` section above - [ ] I wrote clear testing steps that cover the changes made in this PR - [ ] I clearly indicated the environment tests should be run in (Staging vs Production) @@ -62,7 +62,7 @@ This is a checklist for PR authors & reviewers. Please make sure to complete all - [ ] If I created a new component I verified that a similar component doesn't exist in the codebase #### PR Reviewer Checklist -- [ ] I verified the Author pulled `main` before submitting the PR +- [ ] I verified the PR has a small number of commits behind `main` - [ ] I verified the correct issue is linked in the `### Fixed Issues` section above - [ ] I verified testing steps are clear and they cover the changes made in this PR - [ ] I verified the testing environment is mentioned in the test steps