diff --git a/package.json b/package.json index 6227770cdd28..3e743cdc85f0 100644 --- a/package.json +++ b/package.json @@ -46,7 +46,7 @@ "test:debug": "TZ=utc NODE_OPTIONS='--inspect-brk --experimental-vm-modules' jest --runInBand", "perf-test": "NODE_OPTIONS=--experimental-vm-modules npx reassure", "typecheck": "NODE_OPTIONS=--max_old_space_size=8192 tsc", - "lint": "NODE_OPTIONS=--max_old_space_size=8192 eslint . --max-warnings=314 --cache --cache-location=node_modules/.cache/eslint", + "lint": "NODE_OPTIONS=--max_old_space_size=8192 eslint . --max-warnings=313 --cache --cache-location=node_modules/.cache/eslint", "lint-changed": "NODE_OPTIONS=--max_old_space_size=8192 ./scripts/lintChanged.sh", "lint-watch": "npx eslint-watch --watch --changed", "shellcheck": "./scripts/shellCheck.sh", diff --git a/src/libs/CardUtils.ts b/src/libs/CardUtils.ts index c1954578638c..d0f530a7632d 100644 --- a/src/libs/CardUtils.ts +++ b/src/libs/CardUtils.ts @@ -42,14 +42,6 @@ Onyx.connect({ }, }); -let customCardNames: OnyxEntry> = {}; -Onyx.connect({ - key: ONYXKEYS.NVP_EXPENSIFY_COMPANY_CARDS_CUSTOM_NAMES, - callback: (value) => { - customCardNames = value; - }, -}); - /** * @returns string with a month in MM format */ @@ -691,10 +683,6 @@ function getFundIdFromSettingsKey(key: string) { return Number.isNaN(fundID) ? CONST.DEFAULT_NUMBER_ID : fundID; } -function getCustomCardName(cardID: string) { - return customCardNames?.[cardID]; -} - export { isExpensifyCard, getDomainCards, @@ -745,5 +733,4 @@ export { getPlaidInstitutionIconUrl, getPlaidInstitutionId, getCorrectStepForPlaidSelectedBank, - getCustomCardName, }; diff --git a/src/pages/workspace/companyCards/WorkspaceCompanyCardEditCardNamePage.tsx b/src/pages/workspace/companyCards/WorkspaceCompanyCardEditCardNamePage.tsx index 8959958316bc..64dda6ca311b 100644 --- a/src/pages/workspace/companyCards/WorkspaceCompanyCardEditCardNamePage.tsx +++ b/src/pages/workspace/companyCards/WorkspaceCompanyCardEditCardNamePage.tsx @@ -12,7 +12,7 @@ import useLocalize from '@hooks/useLocalize'; import useOnyx from '@hooks/useOnyx'; import useThemeStyles from '@hooks/useThemeStyles'; import useWorkspaceAccountID from '@hooks/useWorkspaceAccountID'; -import {getCompanyFeeds, getCustomCardName, getDomainOrWorkspaceAccountID} from '@libs/CardUtils'; +import {getCompanyFeeds, getDomainOrWorkspaceAccountID} from '@libs/CardUtils'; import {addErrorMessage} from '@libs/ErrorUtils'; import type {PlatformStackScreenProps} from '@libs/Navigation/PlatformStackNavigation/types'; import {getFieldRequiredErrors} from '@libs/ValidationUtils'; @@ -26,6 +26,7 @@ import ROUTES from '@src/ROUTES'; import type SCREENS from '@src/SCREENS'; import INPUT_IDS from '@src/types/form/EditExpensifyCardNameForm'; import type {CompanyCardFeed} from '@src/types/onyx'; +import isLoadingOnyxValue from '@src/types/utils/isLoadingOnyxValue'; type WorkspaceCompanyCardEditCardNamePageProps = PlatformStackScreenProps; @@ -33,8 +34,8 @@ function WorkspaceCompanyCardEditCardNamePage({route}: WorkspaceCompanyCardEditC const {policyID, cardID} = route.params; const workspaceAccountID = useWorkspaceAccountID(policyID); const bank = decodeURIComponent(route.params.bank); - const [customCardNames] = useOnyx(ONYXKEYS.NVP_EXPENSIFY_COMPANY_CARDS_CUSTOM_NAMES, {canBeMissing: true}); - const defaultValue = customCardNames?.[cardID] ?? getCustomCardName(cardID); + const [customCardNames, customCardNamesMetadata] = useOnyx(ONYXKEYS.NVP_EXPENSIFY_COMPANY_CARDS_CUSTOM_NAMES, {canBeMissing: true}); + const defaultValue = customCardNames?.[cardID]; const {translate} = useLocalize(); const {inputCallbackRef} = useAutoFocusInput(); @@ -65,6 +66,10 @@ function WorkspaceCompanyCardEditCardNamePage({route}: WorkspaceCompanyCardEditC return errors; }; + if (isLoadingOnyxValue(customCardNamesMetadata)) { + return null; + } + return (