diff --git a/src/components/MenuItem.js b/src/components/MenuItem.js index e1f525899509..d707aa17a485 100644 --- a/src/components/MenuItem.js +++ b/src/components/MenuItem.js @@ -63,7 +63,7 @@ const defaultProps = { brickRoadIndicator: '', floatRightAvatars: [], shouldStackHorizontally: false, - avatarSize: undefined, + avatarSize: CONST.AVATAR_SIZE.DEFAULT, floatRightAvatarSize: undefined, shouldBlockSelection: false, hoverAndPressStyle: [], @@ -150,7 +150,7 @@ function MenuItem(props) { isHovered={isHovered} isPressed={pressed} icons={props.icon} - size={CONST.AVATAR_SIZE.DEFAULT} + size={props.avatarSize} secondAvatarStyle={[ StyleUtils.getBackgroundAndBorderStyle(themeColors.sidebar), pressed ? StyleUtils.getBackgroundAndBorderStyle(themeColors.buttonPressedBG) : undefined, @@ -159,7 +159,7 @@ function MenuItem(props) { /> )} {Boolean(props.icon) && !_.isArray(props.icon) && ( - + {props.iconType === CONST.ICON_TYPE_ICON && ( )} diff --git a/src/components/MultipleAvatars.js b/src/components/MultipleAvatars.js index 3b20d99fa2ea..f6f9a6c544ea 100644 --- a/src/components/MultipleAvatars.js +++ b/src/components/MultipleAvatars.js @@ -71,9 +71,25 @@ const defaultProps = { maxAvatarsInRow: CONST.AVATAR_ROW_SIZE.DEFAULT, }; +function getContainerStyles(size) { + let containerStyles; + + switch (size) { + case CONST.AVATAR_SIZE.SMALL: + containerStyles = [styles.emptyAvatarSmall, styles.emptyAvatarMarginSmall]; + break; + case CONST.AVATAR_SIZE.SMALLER: + containerStyles = [styles.emptyAvatarSmaller, styles.emptyAvatarMarginSmaller]; + break; + default: + containerStyles = [styles.emptyAvatar, styles.emptyAvatarMargin]; + } + + return containerStyles; +} function MultipleAvatars(props) { const [avatarRows, setAvatarRows] = useState([props.icons]); - let avatarContainerStyles = props.size === CONST.AVATAR_SIZE.SMALL ? [styles.emptyAvatarSmall, styles.emptyAvatarMarginSmall] : [styles.emptyAvatar, styles.emptyAvatarMargin]; + let avatarContainerStyles = getContainerStyles(props.size); const singleAvatarStyle = props.size === CONST.AVATAR_SIZE.SMALL ? styles.singleAvatarSmall : styles.singleAvatar; const secondAvatarStyles = [props.size === CONST.AVATAR_SIZE.SMALL ? styles.secondAvatarSmall : styles.secondAvatar, ...props.secondAvatarStyle]; const tooltipTexts = props.shouldShowTooltip ? _.pluck(props.icons, 'name') : ['']; diff --git a/src/components/ReportActionItem/TaskView.js b/src/components/ReportActionItem/TaskView.js index 7eb77c47980a..0b65fa57a14e 100644 --- a/src/components/ReportActionItem/TaskView.js +++ b/src/components/ReportActionItem/TaskView.js @@ -1,7 +1,6 @@ import React, {useEffect} from 'react'; import {View} from 'react-native'; import PropTypes from 'prop-types'; -import lodashGet from 'lodash/get'; import reportPropTypes from '../../pages/reportPropTypes'; import withLocalize, {withLocalizePropTypes} from '../withLocalize'; import withWindowDimensions from '../withWindowDimensions'; @@ -13,8 +12,7 @@ import MenuItemWithTopDescription from '../MenuItemWithTopDescription'; import MenuItem from '../MenuItem'; import styles from '../../styles/styles'; import * as ReportUtils from '../../libs/ReportUtils'; -import * as PersonalDetailsUtils from '../../libs/PersonalDetailsUtils'; -import * as UserUtils from '../../libs/UserUtils'; +import * as OptionsListUtils from '../../libs/OptionsListUtils'; import * as StyleUtils from '../../styles/StyleUtils'; import * as Task from '../../libs/actions/Task'; import * as PolicyUtils from '../../libs/PolicyUtils'; @@ -49,7 +47,6 @@ function TaskView(props) { const isCompleted = ReportUtils.isCompletedTaskReport(props.report); const isOpen = ReportUtils.isOpenTaskReport(props.report); const isCanceled = ReportUtils.isCanceledTaskReport(props.report); - const avatarURL = lodashGet(PersonalDetailsUtils.getPersonalDetailsByIDs([props.report.managerID], props.currentUserPersonalDetails.accountID), [0, 'avatar'], ''); const policy = ReportUtils.getPolicy(props.report.policyID); const canEdit = PolicyUtils.isPolicyAdmin(policy) || Task.isTaskAssigneeOrTaskOwner(props.report, props.currentUserPersonalDetails.accountID); const disableState = !canEdit || !isOpen; @@ -117,7 +114,7 @@ function TaskView(props) {