From e6d788b983a726f802dc6165176528ed3dec0b76 Mon Sep 17 00:00:00 2001 From: Jatin Soni Date: Wed, 18 Jan 2023 18:16:31 +0530 Subject: [PATCH 1/4] Remove auto converting room name uppercase letters to lowercase --- src/languages/en.js | 2 +- src/languages/es.js | 2 +- src/libs/RoomNameInputUtils.js | 4 +--- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/languages/en.js b/src/languages/en.js index 49113d6ea460..97cb445bba72 100755 --- a/src/languages/en.js +++ b/src/languages/en.js @@ -1036,7 +1036,7 @@ export default { createRoom: 'Create room', roomAlreadyExistsError: 'A room with this name already exists', roomNameReservedError: 'A room on this workspace already uses this name', - roomNameInvalidError: 'Room names can only contain letters, numbers and hyphens', + roomNameInvalidError: 'Room names can only include lowercase letters, numbers and hyphens', pleaseEnterRoomName: 'Please enter a room name', pleaseSelectWorkspace: 'Please select a workspace', renamedRoomAction: ({oldName, newName}) => ` renamed this room from ${oldName} to ${newName}`, diff --git a/src/languages/es.js b/src/languages/es.js index f3853d71cb95..ef91d8858530 100644 --- a/src/languages/es.js +++ b/src/languages/es.js @@ -1038,7 +1038,7 @@ export default { createRoom: 'Crea una sala de chat', roomAlreadyExistsError: 'Ya existe una sala con este nombre', roomNameReservedError: 'Una sala en este espacio de trabajo ya usa este nombre', - roomNameInvalidError: 'Los nombres de las salas solo pueden contener letras, números y guiones', + roomNameInvalidError: 'Los nombres de las habitaciones solo pueden incluir letras minúsculas, números y guiones', pleaseEnterRoomName: 'Por favor, escribe el nombre de una sala', pleaseSelectWorkspace: 'Por favor, selecciona un espacio de trabajo', renamedRoomAction: ({oldName, newName}) => ` cambió el nombre de la sala de ${oldName} a ${newName}`, diff --git a/src/libs/RoomNameInputUtils.js b/src/libs/RoomNameInputUtils.js index 6c2ee31775f9..51c6b5a9d8ca 100644 --- a/src/libs/RoomNameInputUtils.js +++ b/src/libs/RoomNameInputUtils.js @@ -3,15 +3,13 @@ import CONST from '../CONST'; /** * Modifies the room name in the following ways: * - Replaces spaces with dashes - * - Makes all letters lowercase * * @param {String} roomName * @returns {String} */ function modifyRoomName(roomName) { const modifiedRoomNameWithoutHash = roomName - .replace(/ /g, '-') - .toLowerCase(); + .replace(/ /g, '-'); return `${CONST.POLICY.ROOM_PREFIX}${modifiedRoomNameWithoutHash}`; } From c2dbc40bd46ec866c6204c14952b576e00a632e5 Mon Sep 17 00:00:00 2001 From: Jatin Soni Date: Wed, 18 Jan 2023 19:17:17 +0530 Subject: [PATCH 2/4] Change spanish translation --- src/languages/es.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/languages/es.js b/src/languages/es.js index ef91d8858530..f7a911c20758 100644 --- a/src/languages/es.js +++ b/src/languages/es.js @@ -1038,7 +1038,7 @@ export default { createRoom: 'Crea una sala de chat', roomAlreadyExistsError: 'Ya existe una sala con este nombre', roomNameReservedError: 'Una sala en este espacio de trabajo ya usa este nombre', - roomNameInvalidError: 'Los nombres de las habitaciones solo pueden incluir letras minúsculas, números y guiones', + roomNameInvalidError: 'Los nombres de las salas solo pueden contener minúsculas, números y guiones', pleaseEnterRoomName: 'Por favor, escribe el nombre de una sala', pleaseSelectWorkspace: 'Por favor, selecciona un espacio de trabajo', renamedRoomAction: ({oldName, newName}) => ` cambió el nombre de la sala de ${oldName} a ${newName}`, From a8720b2af08f6869ae428e9ebbd0383f3aa34bc8 Mon Sep 17 00:00:00 2001 From: Jatin Soni Date: Wed, 18 Jan 2023 23:13:05 +0530 Subject: [PATCH 3/4] Change comment --- src/libs/RoomNameInputUtils.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/libs/RoomNameInputUtils.js b/src/libs/RoomNameInputUtils.js index 51c6b5a9d8ca..7445f1a356a0 100644 --- a/src/libs/RoomNameInputUtils.js +++ b/src/libs/RoomNameInputUtils.js @@ -1,9 +1,7 @@ import CONST from '../CONST'; /** - * Modifies the room name in the following ways: - * - Replaces spaces with dashes - * + * Replaces spaces with dashes * @param {String} roomName * @returns {String} */ From af406df688b9b63b9ba1e10acb08636ae5bf3b28 Mon Sep 17 00:00:00 2001 From: Jatin Soni Date: Wed, 18 Jan 2023 23:16:09 +0530 Subject: [PATCH 4/4] Add line space between comment and param --- src/libs/RoomNameInputUtils.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libs/RoomNameInputUtils.js b/src/libs/RoomNameInputUtils.js index 7445f1a356a0..3940996ec3fa 100644 --- a/src/libs/RoomNameInputUtils.js +++ b/src/libs/RoomNameInputUtils.js @@ -2,6 +2,7 @@ import CONST from '../CONST'; /** * Replaces spaces with dashes + * * @param {String} roomName * @returns {String} */