Skip to content

Commit 6783079

Browse files
committed
- Prevent running rush default default
1 parent d2a3d87 commit 6783079

4 files changed

Lines changed: 10 additions & 1 deletion

File tree

rush

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1596,13 +1596,17 @@ rush_default_command() {
15961596

15971597
# src/commands/default.sh
15981598
repo=${args[repo]}
1599+
1600+
[[ $repo != "default" ]] || abort "cannot use 'default' as the source repo"
1601+
15991602
repo_path=$(config_get "$repo")
16001603

16011604
[[ $repo_path ]] || abort "repo not found: $repo"
16021605

16031606
config_set "default" "$repo_path"
16041607
config_del "$repo"
16051608
say "default" "$repo ($repo_path)"
1609+
16061610
}
16071611

16081612
# :command.function

src/commands/default.sh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
11
## Collect variables
22
repo=${args[repo]}
3+
4+
[[ $repo != "default" ]] || abort "cannot use 'default' as the source repo"
5+
36
repo_path=$(config_get "$repo")
47

58
## Verify we have everything we need
69
[[ $repo_path ]] || abort "repo not found: $repo"
710

811
config_set "default" "$repo_path"
912
config_del "$repo"
10-
say "default" "$repo ($repo_path)"
13+
say "default" "$repo ($repo_path)"
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
cannot use 'default' as the source repo

test/approve

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ describe "default"
5555
approve "rush default" || return 0
5656
approve "rush default -h"
5757
approve "rush default sample"
58+
approve "rush default default" || return 0
5859

5960
describe "get"
6061
approve "rush add sample ~/rush-repos/sample-repo"

0 commit comments

Comments
 (0)