[eno] Adding more Eno metrics#607
Draft
ruinan-liu wants to merge 2 commits into
Draft
Conversation
Agent-Logs-Url: https://github.com/Azure/eno/sessions/ef10f79c-a010-4d7e-bf80-ac46a5dad413 Co-authored-by: ruinan-liu <72321026+ruinan-liu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add observability metrics for Eno synthesis and reconciliation
Implements the gaps documented in docs/observability-gaps.md.
New metrics:
Bug fix:
second-named buckets, sending 100% of samples to +Inf. Fixed in place
since existing data was already unusable.
Implementation notes:
atomic.Pointer[func() int] mailbox so they can be registered at init()
time before their queue exists.
on the Controller's TypedOptions; intercepts the same typed queue
controller-runtime would have constructed by default.
workqueue in NewResourceSliceWriteBuffer.
workqueue.RateLimitingInterface to the typed
workqueue.TypedRateLimitingInterface[types.NamespacedName], dropping
the interface{} cast in processQueueItem.