fix(pwsh): preserve hyphenated native options#60
Merged
Conversation
Follow-ups from the #52 review: - hoist the equals-form option split into a shared NativeFlagSyntax so the bash and PowerShell parsers cannot drift on a rule SPEC.POWERSHELL §7.3 requires to stay identical - a colon value under an `=`-bearing parameter name now safe-fails to DynamicSkip. PowerShell reads `-Path=C:\Windows` as parameter `-Path=C:` plus argument `\Windows`, a name no cmdlet can bind, so the value's role is unknowable and we must not hand the gate a confident literal - `-?` lexes as one parameter token. IsParameterStart already admitted `?`, but the name-continuation predicate did not, so `Get-Help -?` came out as a bare `-` flag plus a `?` glob - correct the comment on the native non-equals branch, which handles every option shape rather than only the colon form Verified against the real pwsh tokenizer; bash/pwsh output stays identical across the native-option sweep.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security impact
This restores path detection for curated native flags such as git --work-tree repo. Previously, a bare path value could be misclassified as a literal and omitted from downstream zone-gate evaluation.
Unknown native flags retain their existing conservative semantics, and dynamic curated path values still safe-fail as DynamicSkip.
Validation
Closes #52